Clean-up the PDFViewer.{increaseScale, decreaseScale} methods
#16171
Conversation
The signatures of these methods were changed in PR 15886, which has now been included in a couple of releases, hence it should hopefully be OK to remove the fallback code-paths now. Also, the methods are updated slightly to be explicit about what options are supported and we'll no longer pass along any arbitrary options to the "private" methods.
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/dc92deb9a595b94/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c75ff8b08faa68f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/c75ff8b08faa68f/output.txt Total script time: 4.17 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/dc92deb9a595b94/output.txt Total script time: 13.36 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c69118214273b20/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/c69118214273b20/output.txt Total script time: 1.23 mins Published |
|
Looks good! |
The signatures of these methods were changed in PR #15886, which has now been included in a couple of releases, hence it should hopefully be OK to remove the fallback code-paths now.
Also, the methods are updated slightly to be explicit about what options are supported and we'll no longer pass along any arbitrary options to the "private" methods.